[dpdk-dev] [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver

[Xu, Rosen]

Hi,

From: David Marchand [mailto:david.marchand at redhat.com]
Sent: Thursday, February 28, 2019 16:32
To: Xu, Rosen <rosen.xu at intel.com>
Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; Zhang, Tianfei <tianfei.zhang at intel.com>; Wei, Dan <dan.wei at intel.com>; Pei, Andy <andy.pei at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>; Chen, Santos <santos.chen at intel.com>; Zhang, Zhang <zhang.zhang at intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver

Really quick look at this.

On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu at intel.com<mailto:rosen.xu at intel.com>> wrote:
diff --git a/drivers/net/ipn3ke/Makefile b/drivers/net/ipn3ke/Makefile
new file mode 100644
index 0000000..03f2145
--- /dev/null
+++ b/drivers/net/ipn3ke/Makefile
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+include $(RTE_SDK)/mk/rte.vars.mk<http://rte.vars.mk>
+
+#
+# library name
+#
+LIB = librte_pmd_ipn3ke.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+#CFLAGS += $(WERROR_FLAGS)

This kind of bypass is likely to be kept as is forever... better fix the issues now.

It will be fixed in V2.

diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke_ethdev.c
new file mode 100644
index 0000000..e691f68
--- /dev/null
+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c
[snip]
+
+RTE_INIT(ipn3ke_afu_init_log);
+static void
+ipn3ke_afu_init_log(void)
+{
+       ipn3ke_afu_logtype = rte_log_register("driver.afu.ipn3ke");
+       if (ipn3ke_afu_logtype >= 0)
+               rte_log_set_level(ipn3ke_afu_logtype, RTE_LOG_NOTICE);

rte_log_register_type_and_pick_level() would be better.
It will be fixed in V2.

diff --git a/drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map b/drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map
new file mode 100644
index 0000000..ef35398
--- /dev/null
+++ b/drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map
@@ -0,0 +1,4 @@
+DPDK_2.0 {
+
+       local: *;
+};

Ok this driver has been around for a long time, but now, we are in 2019, please fix :-)
It will be fixed in V2.

--
David Marchand