[dpdk-dev] [PATCH v2 2/2] Fix variable assignment.

Thomas Monjalon thomas at monjalon.net
Thu Feb 28 12:14:23 CET 2019


Hi,

Few minor comments,

The title should start with "devtools:" and not end with dot.
One suggestion:
	devtools: fix result of svg include check

14/02/2019 20:35, Michael Santana:
> Fix trivial bug. In sh shell, 'foo = 1' is not the same as
> 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
> as a command, rather than a simple variable assignment.

Yes, good catch, thanks.

> Signed-off-by: Michael Santana <msantana at redhat.com>
> Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot")

The reference should be:
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
and it should be followed by:
Cc: stable at dpdk.org
in order to be backported.





More information about the dev mailing list