[dpdk-dev] [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter

[Zhao1, Wei]

Hi, qi  

> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, January 2, 2019 9:19 AM
> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> Cc: stable at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Peng, Yuan
> <yuan.peng at intel.com>
> Subject: RE: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter
> 
> HI Wei:
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, December 25, 2018 1:45 PM
> > To: dev at dpdk.org
> > Cc: stable at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhang, Qi Z
> > <qi.z.zhang at intel.com>; Peng, Yuan <yuan.peng at intel.com>; Zhao1, Wei
> > <wei.zhao1 at intel.com>
> > Subject: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter
> >
> > There is need for users to use flexible byte filter on x550.
> > x550 support IP mode and tunnel mode flexible byte filter.
> > tunnel mode flexible byte filter is used for vxlan packets and so on.
> > It can be used combined with FDIR tunnel filter.
> > By now, ixgbe PMD flow parer code do not support tunnel mode flexible
> > byte filter for x550, So I have to enable it in function
> ixgbe_parse_fdir_filter_tunnel().
> > Although IP mode flexible byte filter parser is support in function
> > ixgbe_parse_fdir_filter_normal(), but some flow like  "flow create 0
> > ingress pattern raw pattern is 0xab / end actions queue index 3 / end"
> > need to be support, so parser code also need change a little.
> > This patch enable all of these feature.
> 
> I would suggest to divide this patch into 3 patches 1. more accurate input set
> mask setup (include all changes in ixgbe_fdir.c) 2. support flexbyte without IP
> layer (include changes in ixgbe_parse_fdir_filter_normal) 3. support flexbyte
> in tunnel mode (include changes in ixgbe_parse_fdir_flilter_tunnel)
> 
> Btw, please make sure to sync the acceptable flow pattern/action description
> above function ixgbe_parse_fdir_filter_xxxxx to their new behaviors

There will be 4 patch in this set, because there is other for flow_cmdline parser, is that ok?

> 
> Thanks
> Qi