[dpdk-dev] [dpdk-stable] [PATCH] doc: fix a typo in testpmd user guide

Ferruh Yigit ferruh.yigit at intel.com
Thu Jan 3 17:35:35 CET 2019


On 1/3/2019 2:00 PM, Iremonger, Bernard wrote:
> Hi Rami,
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rami Rosen
>> Sent: Thursday, December 27, 2018 7:59 PM
>> To: dev at dpdk.org
>> Cc: stable at dpdk.org; wisamm at mellanox.com; Rami Rosen
>> <ramirose at gmail.com>
>> Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
>>
>> This patch fixes a typo in testpmd user guide.
>>
>> Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Rami Rosen <ramirose at gmail.com>
>> ---
>>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> index cbf23e928..ab40b9f5f 100644
>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> @@ -1149,7 +1149,7 @@ set eth-peer
>>
>>  Set the forwarding peer address for certain port::
>>
>> -   testpmd> set eth-peer (port_id) (perr_addr)
>> +   testpmd> set eth-peer (port_id) (peer_addr)
>>
>>  This is equivalent to the ``--eth-peer`` command-line option.
>>
>> --
>> 2.19.2
> 
> ./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_testpmd/doc-fix-a-typo-in-testpmd-user-guide.patch
> 
> ### doc: fix a typo in testpmd user guide
> 
> WARNING:BAD_SIGN_OFF: Duplicate signature
> #25: 
> Signed-off-by: Rami Rosen <ramirose at gmail.com>
> 
> total: 0 errors, 1 warnings, 8 lines checked

There is no double sign-off, this is because Wisam added his ack without quoting
original mail, so patchwork observed second sign-off and added it.

So original patch is OK, please check the error message before copy-paste it
from the console.

And with your error copy-paste, patchwork observed sign-off again and now there
are three copy same sign-off :)

> 
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
>  
> 



More information about the dev mailing list