[dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support

Stephen Hemminger stephen at networkplumber.org
Fri Jan 4 20:42:35 CET 2019


On Fri,  4 Jan 2019 13:59:42 +0000
Eelco Chaudron <echaudro at redhat.com> wrote:

> This patch adds support for RFC4115 trTCM meters.
> 
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>



Fix comment formatting.

### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#172: FILE: lib/librte_meter/rte_meter.h:59:
+/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and EBS
+parameters only count bytes of IP packets and do not include link specific

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: lib/librte_meter/rte_meter.h:61:
+none-zero respectively.*/

WARNING:LONG_LINE_COMMENT: line over 80 characters
#176: FILE: lib/librte_meter/rte_meter.h:63:
+	uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */

WARNING:LONG_LINE_COMMENT: line over 80 characters
#177: FILE: lib/librte_meter/rte_meter.h:64:
+	uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes per second. */

WARNING:LONG_LINE_COMMENT: line over 80 characters
#355: FILE: lib/librte_meter/rte_meter.h:406:
+	/**< Number of bytes currently available in the excess(E) token bucket */

total: 0 errors, 5 warnings, 356 lines checked


More information about the dev mailing list