[dpdk-dev] [PATCH v3] doc: add meson build to contributing guide
Varghese, Vipin
vipin.varghese at intel.com
Thu Jan 10 17:37:56 CET 2019
HI Thomas
snipped
> > >
> > > +Compliation of patches has to be tested using meson::
> > > +
> > > + ./devtools/test-meson-builds.sh
> > > +
> > > +This will test for shared and static builds. If gcc arm cross
> > > +compiler is installed, cross build is tested too.
> > >
> > > Sending Patches
> > > ---------------
> >
> > Ran the script all runs fine
> >
> > Tested-by: Marko Kovacevic <marko.kovacevic at intel.com>
> > Acked-by: Marko Kovacevic <marko.kovacevic at intel.com>
>
> Yes we must add such explanation, but it can be improved.
>
> We should make clear that meson must be tested in addition of make.
In Patch ' https://patches.dpdk.org/patch/47562/´as per suggestion Bruce, we have given emphasis on ' Compliation of patches has to be tested using meson'. In my opinion, this is bare minimum one liner, which is required to be executed for any patch before sending.
>
> We could be more explicit about cross-compilation, saying on x86 host, both
> x86 and Arm can be compiled thanks to the cross compilers.
>
I believe this should be covered about compilation section and features.
> More details:
> - s/Compliation/Compilation/
> - the double blank line is removed before next header
>
>
More information about the dev
mailing list