[dpdk-dev] [PATCH 3/4] net/enic: support multicast filtering

[Ferruh Yigit]

On 12/10/2018 6:28 PM, Hyong Youb Kim wrote:
> The VIC hardware has 64 MAC filters per vNIC, which can be either
> unicast or multicast. Use one half for unicast and the other half for
> multicast, as the VIC kernel drivers for Linux and Windows do.
> 
> Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
> Reviewed-by: John Daley <johndale at cisco.com>

<...>

> +static void debug_log_add_del_addr(struct ether_addr *addr, bool add)
> +{
> +	char mac_str[ETHER_ADDR_FMT_SIZE];
> +	if (rte_log_get_level(enicpmd_logtype_init) == RTE_LOG_DEBUG) {
> +		ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr);
> +		PMD_INIT_LOG(ERR, " %s address %s\n",
> +			     add ? "add" : "remove", mac_str);
> +	}
> +}

Why logging with 'ERR' level after checking if 'DEBUG' level is set?

And why need that check at all?