[dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

Wiles, Keith keith.wiles at intel.com
Fri Jan 11 20:50:57 CET 2019



> On Jan 11, 2019, at 1:49 PM, Stephen Hemminger <stephen at networkplumber.org> wrote:
> 
> On Fri, 11 Jan 2019 19:37:00 +0000
> "Wiles, Keith" <keith.wiles at intel.com> wrote:
> 
>>> +/* make sure name is a possible Linux network device name */
>>> +static bool is_valid_iface(const char *name)  
>> 
>> I am sorry, but the function name must be on the next line as per the style. I know you do not like it, but that is what the style states.
> 
> I am surprised because most of the DPDK follows kernel style.
> And in kernel style one line is preferred if line is not too long.

Last time I looked at the DPDK coding style it is not the case. We do not really follow Linux coding style only started with it and made changes :-(

Regards,
Keith



More information about the dev mailing list