[dpdk-dev] [PATCH v2 2/7] net/tap: allow full length names
Stephen Hemminger
stephen at networkplumber.org
Fri Jan 11 21:35:15 CET 2019
The code for set_interface_name was incorrectly assuming that
space for null byte was necessary with snprintf/strlcpy.
Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by Keith Wiles <keith.wiles at intel.com>
---
drivers/net/tap/rte_eth_tap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 1c00681ba0eb..11e402e42bd0 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1892,10 +1892,10 @@ set_interface_name(const char *key __rte_unused,
char *name = (char *)extra_args;
if (value)
- strlcpy(name, value, RTE_ETH_NAME_MAX_LEN - 1);
+ strlcpy(name, value, RTE_ETH_NAME_MAX_LEN);
else
- snprintf(name, RTE_ETH_NAME_MAX_LEN - 1, "%s%d",
- DEFAULT_TAP_NAME, (tap_unit - 1));
+ snprintf(name, RTE_ETH_NAME_MAX_LEN, "%s%d",
+ DEFAULT_TAP_NAME, tap_unit - 1);
return 0;
}
--
2.20.1
More information about the dev
mailing list