[dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field

Stephen Hemminger stephen at networkplumber.org
Wed Jan 16 00:11:51 CET 2019


On Thu, 20 Dec 2018 12:16:09 +0000
Reshma Pattan <reshma.pattan at intel.com> wrote:

>  void
> -rte_sched_port_pkt_write(struct rte_mbuf *pkt,
> -			 uint32_t subport, uint32_t pipe, uint32_t traffic_class,
> +rte_sched_port_pkt_write(struct rte_sched_port *port,
> +			 struct rte_mbuf *pkt,
> +			 uint32_t subport, uint32_t pipe,
> +			 uint32_t traffic_class,
>  			 uint32_t queue, enum rte_meter_color color)

Sorry I didn't notice this earlier, but changing the function signature like
this is a complete ABI breakage.  Old code will be passing different arguments than
new code; therefore this change breaks both source and binary compatibility.

Is 19.02 supposed to be an ABI/API breaking release? Or only an incremental update.



More information about the dev mailing list