[dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

Thomas Monjalon thomas at monjalon.net
Thu Jan 17 18:26:12 CET 2019


15/01/2019 11:01, David Hunt:
> From: Liang Ma <liang.j.ma at intel.com>
> 
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> Coverity issue: 328528
> 
> v2: focus just on the resource leak. Remove additional code around
>     Turbo Boost frequency handling.
> 
> Signed-off-by: Liang Ma <liang.j.ma at intel.com>
> Reviewed-by: Lei Yao <lei.a.yao at intel.com>
> Tested-by: Lei Yao <lei.a.yao at intel.com>
> Signed-off-by: David Hunt <david.hunt at intel.com>
> ---
> --- a/lib/librte_power/power_pstate_cpufreq.c
> +++ b/lib/librte_power/power_pstate_cpufreq.c
>  	f_max = fopen(fullpath_max, "rw+");
> +
> +	if (f_max == NULL)
> +		fclose(f_min);

No need to insert a blank line before "if". Removing on apply.

Applied, thanks




More information about the dev mailing list