[dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect place in Tx path
Rasesh Mody
rmody at marvell.com
Fri Jan 18 17:58:50 CET 2019
>From: dev <dev-bounces at dpdk.org> On Behalf Of Shahed Shaikh
>Sent: Friday, January 18, 2019 2:30 AM
>
>Incorrect placement of prefetch in Tx path is causing a performance drop of
>around ~2% on AMD platform.
>
>Fixes: 2ea6f76aff40 ("qede: add core driver")
>Cc: stable at dpdk.org
>
>Signed-off-by: Shahed Shaikh <shshaikh at marvell.com>
>---
Acked-by: Rasesh Mody <rmody at marvell.com>
> drivers/net/qede/qede_rxtx.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
>index 684c4ae..eda19b2 100644
>--- a/drivers/net/qede/qede_rxtx.c
>+++ b/drivers/net/qede/qede_rxtx.c
>@@ -2181,7 +2181,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf
>**tx_pkts, uint16_t nb_pkts)
>
> txq->nb_tx_avail -= bd1->data.nbds;
> txq->sw_tx_prod++;
>- rte_prefetch0(txq->sw_tx_ring[TX_PROD(txq)].mbuf);
> bd_prod =
> rte_cpu_to_le_16(ecore_chain_get_prod_idx(&txq->tx_pbl));
> #ifdef RTE_LIBRTE_QEDE_DEBUG_TX
>--
>2.7.4
More information about the dev
mailing list