[dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library()
Bruce Richardson
bruce.richardson at intel.com
Tue Jan 22 15:25:15 CET 2019
On Tue, Jan 22, 2019 at 01:10:52PM +0000, Luca Boccassi wrote:
> Whenever possible (if the library ships a pkg-config file) use meson's
> dependency() function to look for it, as it will automatically add it
> to the Requires.private list if needed, to allow for static builds to
> succeed for reverse dependencies of DPDK. Otherwise the recursive
> dependencies are not parsed, and users doing static builds have to
> resolve them manually by themselves.
> When using this API avoid additional checks that are superfluous and
> take extra time, and avoid adding the linker flag manually which causes
> it to be duplicated.
>
> Signed-off-by: Luca Boccassi <bluca at debian.org>
> ---
> v2: split libbsd change in a separate commit, remove CC to stable
> as a meson bump will be required
> v4: update comment in drivers/meson.build to clarify role of
> pkgconfig_extra_libs
> v5: remove -lz from drivers/compress/zlib
>
This is a good idea. Using dependency objects is much better than trying to
track flags manually.
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
More information about the dev
mailing list