[dpdk-dev] [PATCH] Introduce travis builds for github repositories

Aaron Conole aconole at redhat.com
Thu Jan 24 21:02:47 CET 2019


Thomas Monjalon <thomas at monjalon.net> writes:

> 23/01/2019 23:07, Michael Santana:
>> +if [ "${NINJABUILD}" == "1" ]; then
>> +    meson build
>> +    ninja -C build
>> +else
>> +    make config T=x86_64-native-linuxapp-${CC}
>> +    if [ "${SHARED}" == "1" ]; then
>> +        set_conf build CONFIG_RTE_BUILD_SHARED_LIB y
>> +    fi
>> +
>> +    if [ "${KERNEL}" == "1" ]; then
>> +        echo Unsupported kernel builds at the moment
>> +    fi
>
> Do we really want to support the "make system", given that it is going
> to be deprecated this year?

I prefer to keep it for as long as 'make' is a supported build system.
Once 'make' is deprecated (or removed, either one), it should definitely
be dropped.

Currently, the meson build isn't as well documented (for example, the
linux build guide doesn't even refer to meson).  So, most likely the
average developer who just wants to make a small contribution will run
'make' to build DPDK, and hasn't learned yet how to work with
meson/ninja.

Are there plans for which release will officially mark 'make' as
deprecated?  If it will be 19.02, then let's drop this check in v2,
since it won't be around long enough to provide any benefit.  If it will
be 19.05 or 19.08 then I think it probably will provide some value.


More information about the dev mailing list