[dpdk-dev] [PATCH] test: skip test when cores do not meet requirement

Michael Santana msantana at redhat.com
Mon Jun 3 20:59:56 CEST 2019


If the running platform does not meet the required 4 cores or more to run
tests rcu_qsbr_autotest and hash_readwrite_autotest meson reports them as
failed tests when they really should be skipped tests.

The working change can be shown here:
FAIL:
https://travis-ci.com/Maickii/dpdk-2/jobs/205045946#L645
https://travis-ci.com/Maickii/dpdk-2/jobs/205045946#L671
SKIP:
https://travis-ci.com/Maickii/dpdk-2/jobs/205047293#L645
https://travis-ci.com/Maickii/dpdk-2/jobs/205047293#L671

Signed-off-by: Michael Santana <msantana at redhat.com>
---
 app/test/test_hash_readwrite.c | 2 +-
 app/test/test_rcu_qsbr.c       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c
index 480ae97d8..a34193e98 100644
--- a/app/test/test_hash_readwrite.c
+++ b/app/test/test_hash_readwrite.c
@@ -621,7 +621,7 @@ test_hash_readwrite_main(void)
 	if (rte_lcore_count() <= 2) {
 		printf("More than two lcores are required "
 			"to do read write test\n");
-		return -1;
+		return TEST_SKIPPED;
 	}
 
 	RTE_LCORE_FOREACH_SLAVE(core_id) {
diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 92ab0c20a..f3e02dd3f 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -953,8 +953,8 @@ test_rcu_qsbr_main(void)
 		return -1;
 
 	if (num_cores < 4) {
-		printf("Test failed! Need 4 or more cores\n");
-		goto test_fail;
+		printf("Test skipped! Need 4 or more cores\n");
+		return TEST_SKIPPED;
 	}
 
 	/* Error-checking test cases */
-- 
2.20.1



More information about the dev mailing list