[dpdk-dev] [PATCH 08/12] net/ena: remove unnecessary cast

Ferruh Yigit ferruh.yigit at intel.com
Wed Jun 5 16:28:19 CEST 2019


On 5/29/2019 8:14 PM, Stephen Hemminger wrote:
> The device private pointer (dev_private) is of type void *
> therefore no cast is necessary in C.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

<...>

> @@ -768,9 +765,7 @@ static int ena_link_update(struct rte_eth_dev *dev,
>  			   __rte_unused int wait_to_complete)
>  {
>  	struct rte_eth_link *link = &dev->data->dev_link;
> -	struct ena_adapter *adapter;
> -
> -	adapter = (struct ena_adapter *)(dev->data->dev_private);
> +	struct ena_adapter *adapter =dev->data->dev_private;

Needs space around "=", fixing while merging.

<...>

> @@ -2506,8 +2490,7 @@ static int ena_xstats_get(struct rte_eth_dev *dev,
>  			  struct rte_eth_xstat *xstats,
>  			  unsigned int n)
>  {
> -	struct ena_adapter *adapter =
> -			(struct ena_adapter *)(dev->data->dev_private);
> +	struct ena_adapter *adapter =dev->data->dev_private;

Needs space around "=", fixing while merging.


More information about the dev mailing list