[dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support

[Ferruh Yigit]

On 6/6/2019 4:59 PM, Jerin Jacob Kollanukkaran wrote:
> 
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> Sent: Thursday, June 6, 2019 9:20 PM
>> To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; dev at dpdk.org; John
>> McNamara <john.mcnamara at intel.com>; Marko Kovacevic
>> <marko.kovacevic at intel.com>; Nithin Kumar Dabilpuram
>> <ndabilpuram at marvell.com>; Kiran Kumar Kokkilagadda
>> <kirankumark at marvell.com>
>> Cc: Harman Kalra <hkalra at marvell.com>
>> Subject: Re: [dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support
>>
>> On 6/2/2019 4:24 PM, jerinj at marvell.com wrote:
>>> From: Jerin Jacob <jerinj at marvell.com>
>>>
>>> The fields from CQE needs to be converted to ptype and rx ol flags in
>>> mbuf. This patch adds create lookup memory for those items to be used
>>> in Fastpath.
>>>
>>> Signed-off-by: Jerin Jacob <jerinj at marvell.com>
>>> Signed-off-by: Kiran Kumar K <kirankumark at marvell.com>
>>> Signed-off-by: Harman Kalra <hkalra at marvell.com>
>>
>> <...>
>>
>>> @@ -1,4 +1,7 @@
>>>  DPDK_19.05 {
>>> +	global:
>>> +
>>> +	otx2_nix_fastpath_lookup_mem_get;
>>
>> Why this function is in the .map file?
> 
> It is used by octeontx2 eventdev driver in driver/event/octeontx2

OK, any way to get rid of it, like using event-eth adapters etc ?

> 
>> .map file is for the functions that this PMD exposes to application to call, this
>> look intended to use within the library itself, if so no need to be in .map file.
>>
>>>
>>>  	local: *;
>>>  };
>>>
>