[dpdk-dev] [PATCH v1 58/58] doc: add Marvell OCTEON TX2 ethdev documentation

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> Sent: Thursday, June 6, 2019 10:20 PM
> To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; dev at dpdk.org; Thomas
> Monjalon <thomas at monjalon.net>; John McNamara
> <john.mcnamara at intel.com>; Marko Kovacevic
> <marko.kovacevic at intel.com>; Nithin Kumar Dabilpuram
> <ndabilpuram at marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark at marvell.com>; Vamsi Krishna Attunuru
> <vattunuru at marvell.com>
> Subject: Re: [dpdk-dev] [PATCH v1 58/58] doc: add Marvell OCTEON TX2
> ethdev documentation
> 
> On 6/2/2019 4:24 PM, jerinj at marvell.com wrote:
> > From: Jerin Jacob <jerinj at marvell.com>
> >
> > Add Marvell OCTEON TX2 ethdev documentation.
> >
> > This patch also updates the MAINTAINERS file and shared library
> > versions in release_19_08.rst.
> >
> > Cc: John McNamara <john.mcnamara at intel.com>
> > Cc: Thomas Monjalon <thomas at monjalon.net>
> >
> > Signed-off-by: Jerin Jacob <jerinj at marvell.com>
> > Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>
> > Signed-off-by: Kiran Kumar K <kirankumark at marvell.com>
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram at marvell.com>
> 
> <...>
> 
> > +Debugging Options
> > +-----------------
> > +
> > +.. _table_octeontx2_ethdev_debug_options:
> > +
> > +.. table:: OCTEON TX2 ethdev debug options
> > +
> > +   +---+------------+-------------------------------------------------------+
> > +   | # | Component  | EAL log command                                       |
> > +
> +===+============+========================================
> ===============+
> > +   | 1 | NIX        | --log-level='pmd\.net.octeontx2,8'                    |
> > +   +---+------------+-------------------------------------------------------+
> > +   | 2 | NPC        | --log-level='pmd\.net.octeontx2\.flow,8'              |
> > +
> > + +---+------------+--------------------------------------------------
> > + -----+
> 
> Are these log types registered?
> I can't find them, but I may be missed them since not applied whole set.

Yes.

> 
> <...>
> 
> > diff --git a/doc/guides/rel_notes/release_19_05.rst
> > b/doc/guides/rel_notes/release_19_05.rst
> > index b4c6972e3..e925ccf0e 100644
> > --- a/doc/guides/rel_notes/release_19_05.rst
> > +++ b/doc/guides/rel_notes/release_19_05.rst
> 
> Can you please use 19.08 release notes, instead of 19.05.

My bad. Will fix it in v2.

> 
> Also can you please announce the PMD in "New Features" section of the
> release notes?

Yes. I will send a separate patch for the same as there are multiple drivers(ethdev, evendev, mempool, rawdriver for dma)
getting added for octeontx2. I will combine them to single entry in "New Features"