[dpdk-dev] [PATCH v1 56/58] net/octeontx2: add device stop and close operations

Nithin Dabilpuram nithind1988 at gmail.com
Fri Jun 7 07:11:47 CEST 2019


On Thu, Jun 06, 2019 at 05:23:12PM +0100, Ferruh Yigit wrote:
> On 6/2/2019 4:24 PM, jerinj at marvell.com wrote:
> > From: Nithin Dabilpuram <ndabilpuram at marvell.com>
> > 
> > Add device stop, close and reset operations.
> > 
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram at marvell.com>
> > Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>
> 
> <...>
> 
> > @@ -1792,6 +1844,24 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev, bool mbox_close)
> >  	return 0;
> >  }
> >  
> > +static void
> > +otx2_nix_dev_close(struct rte_eth_dev *eth_dev)
> > +{
> > +	otx2_eth_dev_uninit(eth_dev, true);
> > +}
> 
> 'close' should free all PMD resources, with 'RTE_ETH_DEV_CLOSE_REMOVE' flag
> ethdev API can free the ethdev level allocated memory itself.
> 

Agreed, we are adhering to the spec and handling close with RTE_ETH_DEV_CLOSE_REMOVE flag
behavior where close cannot return error and even rte_eth_dev will itself be freed. 
Do you see any issue ?

> 
> 


More information about the dev mailing list