[dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

[Bruce Richardson]

On Thu, Jun 06, 2019 at 12:49:27PM -0700, Stephen Hemminger wrote:
> On Fri,  7 Jun 2019 00:03:54 +0530
> Vipin Varghese <vipin.varghese at intel.com> wrote:
> 
> > Add callback event handler for enqueue dequeue operation on ring.
> > The pre-enqueue and post-dequeue operation on ring is selected to
> > invoke user callback handler.
> > 
> > Signed-off-by: Vipin Varghese <vipin.varghese at intel.com>
> > ---
> 
> NAK
> What is the use case for this? Rings are one of the most used elements
> of DPDK and anything like this will have performance impact.
> 
> And as DPDK goes to more of distribution model, all features have to be
> enabled.
> 
To add callback handlers to a ring, I'd suggest wrapping the ring as an
ethdev using the ring pmd, and then using the ethdev callbacks.

/Bruce