[dpdk-dev] [PATCH 47/49] net/ice/base: enable additional switch rules
Stillwell Jr, Paul M
paul.m.stillwell.jr at intel.com
Fri Jun 7 17:58:46 CEST 2019
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin at redhat.com>
> Sent: Friday, June 7, 2019 5:41 AM
> To: Stillwell Jr, Paul M <paul.m.stillwell.jr at intel.com>; Rong, Leyi
> <leyi.rong at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>
> Cc: dev at dpdk.org; Nowlin, Dan <dan.nowlin at intel.com>
> Subject: Re: [dpdk-dev] [PATCH 47/49] net/ice/base: enable additional
> switch rules
>
>
>
> On 6/5/19 6:34 PM, Stillwell Jr, Paul M wrote:
> >>> if (!s_rule)
> >>> @@ -5576,8 +5606,8 @@ ice_add_adv_rule(struct ice_hw *hw, struct
> >> ice_adv_lkup_elem *lkups,
> >>> s_rule->pdata.lkup_tx_rx.recipe_id = CPU_TO_LE16(rid);
> >>> s_rule->pdata.lkup_tx_rx.act = CPU_TO_LE32(act);
> >>>
> >>> - ice_fill_adv_dummy_packet(lkups, lkups_cnt, rinfo->tun_type,
> >> s_rule,
> >>> - pkt, pkt_len);
> >>> + ice_fill_adv_dummy_packet(lkups, lkups_cnt, s_rule, pkt, pkt_len,
> >>> + pkt_offsets);
> >> Now that ice_fill_adv_dummy_packet() propagates an error, the caller
> >> should do the same.
> >>
> > OK, can we accept this patch and have a separate patch that propagates
> the error? It will take some time to get a patch that propagates the error
> done.
> >
>
> I'm OK with that, do you think it can be done for v19.08?
I believe it will be done for 19.08, it just takes some time due to internal review process. As an FYI: the internal patch that I created to fix this has exposed an issue in our internal testing so thanks for that!
More information about the dev
mailing list