[dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations
Wei, Dan
dan.wei at intel.com
Mon Jun 10 08:27:50 CEST 2019
Thank you for your comments.
> > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > b/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > index 9079b57..84eb0e9 100644
> > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > @@ -223,15 +223,25 @@
> > "LineSideMACType", &mac_type);
> > hw->retimer.mac_type = (int)mac_type;
> >
> > + /* After power on, wait until init done */
> > + while (IPN3KE_READ_REG(hw, IPN3KE_INIT_DONE) != 0x3)
> > + ;
>
> Isn't this dangerous? What do you think putting a limit to the loop?
> And what do you think creating a define for 0x3?
I will add a timeout in the loop. I will create a macro for 0x3.
> <...>
>
> > @@ -355,13 +354,13 @@ static inline uint32_t
> > _ipn3ke_indrct_read(struct ipn3ke_hw *hw,
> >
> > word_offset = (addr & 0x1FFFFFF) >> 2;
> > indirect_value = RCMD | word_offset << 32;
> > - indirect_addrs = hw->hw_addr + (uint32_t)(UPL_BASE | 0x10);
> > + indirect_addrs = hw->hw_addr + (uint32_t)(0x30);
>
> Can you create a macro for 0x30 hardcoded value? And same for below hardcoded values.
I will create macros.
> <...>
>
> > @@ -500,6 +500,7 @@ static inline void _ipn3ke_indrct_write(struct ipn3ke_hw *hw,
> > #define IPN3KE_CLF_RX_TEST (IPN3KE_CLASSIFY_OFFSET + 0x0400)
> >
> > #define IPN3KE_CLF_EM_VERSION (IPN3KE_CLASSIFY_OFFSET + 0x40000 + 0x0000)
> > +#define IPN3KE_CLF_EM_SCRATCH (IPN3KE_CLASSIFY_OFFSET + 0x40000 + 0x0004)
>
> As far as I can see this macro is not used in this patch, why adding it?
I will delete it.
More information about the dev
mailing list