[dpdk-dev] [PATCH 14/39] eventdev: add files for eventmode helper

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Anoob Joseph <anoobj at marvell.com>
> Sent: Monday, June 3, 2019 11:02 PM
> To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Nikhil Rao
> <nikhil.rao at intel.com>; Erik Gabriel Carrillo <erik.g.carrillo at intel.com>;
> Abhinandan Gujjar <abhinandan.gujjar at intel.com>; Bruce Richardson
> <bruce.richardson at intel.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>
> Cc: Anoob Joseph <anoobj at marvell.com>; Narayana Prasad Raju Athreya
> <pathreya at marvell.com>; dev at dpdk.org; Lukas Bartosik
> <lbartosik at marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula at marvell.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>; Nipun Gupta <nipun.gupta at nxp.com>; Harry
> van Haaren <harry.van.haaren at intel.com>; Mattias Rönnblom
> <mattias.ronnblom at ericsson.com>; Liang Ma <liang.j.ma at intel.com>
> Subject: [PATCH 14/39] eventdev: add files for eventmode helper
> 
> Adding files for eventmode helper
> 
> Signed-off-by: Anoob Joseph <anoobj at marvell.com>
> Signed-off-by: Lukasz Bartosik <lbartosik at marvell.com>
> ---
>  lib/librte_eventdev/Makefile                        |  5 +++--
>  lib/librte_eventdev/meson.build                     |  2 ++
>  lib/librte_eventdev/rte_eventmode_helper.c          |  7 +++++++
>  lib/librte_eventdev/rte_eventmode_helper.h          | 15 +++++++++++++++

s/rte_eventmode_helper/rte_event_helper/gc. See below

>  lib/librte_eventdev/rte_eventmode_helper_internal.h |  6 ++++++
>  5 files changed, 33 insertions(+), 2 deletions(-)  create mode 100644
> lib/librte_eventdev/rte_eventmode_helper.c
> +#ifndef _RTE_EVENTMODE_HELPER_H_
> +#define _RTE_EVENTMODE_HELPER_H_

In order to shortened the macros, enums, APIs, I think,
We can change to rte_event_helper from rte_eventmode_here.

> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_EVENTMODE_HELPER_H_ */
> diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> new file mode 100644
> index 0000000..0da7003
> --- /dev/null
> +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> @@ -0,0 +1,6 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (C) 2019 Marvell International Ltd.
> + */
> +#ifndef _RTE_EVENTMODE_HELPER_INTERNAL_H_ #define


Please have this patch for Helper API definition(spec) and remaining patches
for implementation. That would help contract between helper and application.


> +_RTE_EVENTMODE_HELPER_INTERNAL_H_
> +#endif /* _RTE_EVENTMODE_HELPER_INTERNAL_H_ */
> --
> 2.7.4