[dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal

[Neil Horman]

On Mon, Jun 17, 2019 at 07:30:34AM +0000, Hemant Agrawal wrote:
> HI Neil,
> 	The same code of low-level HW driver is shared with different OSs (kernel, uboot etc) and different framework. If we introduce rte_internal in these low-level hw files, it will be a big maintenance issue for NXP. Everytime there is a change or upgrade, it will be a pain. 
> 
Why?  If you don't want to support the use of a project specific tag in other
projects, you can add a global cflag to those like this:
-D__rte_experimental

and the code will be eliminated

I'm not sure what you see as difficult here

Neil

> Regards,
> Hemant
> 
> > -----Original Message-----
> > From: Neil Horman <nhorman at tuxdriver.com>
> > Sent: Thursday, June 13, 2019 7:54 PM
> > To: dev at dpdk.org
> > Cc: Neil Horman <nhorman at tuxdriver.com>; Jerin Jacob Kollanukkaran
> > <jerinj at marvell.com>; Bruce Richardson <bruce.richardson at intel.com>;
> > Thomas Monjalon <thomas at monjalon.net>; Hemant Agrawal
> > <hemant.agrawal at nxp.com>; Shreyansh Jain <shreyansh.jain at nxp.com>
> > Subject: [PATCH v2 05/10] fslmc: identify internal only functions and tag them
> > as __rte_internal
> > Importance: High
> > 
> > Identify functions in fslmc bus driver which are internal (based on
> > their not having an rte_ prefix) and tag them with __rte_internal
> > 
>