[dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert

[Morten Brørup]

> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
> 
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
> 
> Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  drivers/net/bnx2x/bnx2x_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
> b/drivers/net/bnx2x/bnx2x_ethdev.c
> index 45c6c363c077..0ee35e4e4d8e 100644
> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> @@ -150,7 +150,6 @@ static void bnx2x_periodic_start(void *param)
>  		if (ret) {
>  			PMD_DRV_LOG(ERR, sc, "Unable to start periodic"
>  					     " timer rc %d", ret);
> -			assert(false && "Unable to start periodic timer");
>  		}
>  	}
>  }
> --
> 2.20.1
> 

Acked-by: Morten Brørup <mb at smartsharesystems.com>