[dpdk-dev] [PATCH v8 1/1] eventdev: add new software event timer adapter

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Jerin Jacob Kollanukkaran <jerinj at marvell.com>
> Sent: Monday, June 24, 2019 11:43 AM
> To: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>;
> jerin.jacob at caviumnetworks.com
> Cc: mattias.ronnblom at ericsson.com; pbhagavatula at caviumnetworks.com;
> Honnappa.Nagarahalli at arm.com; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v8 1/1] eventdev: add new software event timer
> adapter
> 
> > -----Original Message-----
> > From: dev <dev-bounces at dpdk.org> On Behalf Of Erik Gabriel Carrillo
> > Sent: Wednesday, June 19, 2019 9:56 PM
> > To: jerin.jacob at caviumnetworks.com
> > Cc: mattias.ronnblom at ericsson.com; pbhagavatula at caviumnetworks.com;
> > Honnappa.Nagarahalli at arm.com; dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH v8 1/1] eventdev: add new software event
> > timer adapter
> >
> > This patch introduces a new version of the event timer adapter software
> > PMD. In the original design, timer event producer lcores in the primary and
> > secondary processes enqueued event timers into a ring, and a service core in
> > the primary process dequeued them and processed them further.  To
> > improve performance, this version does away with the ring and lets lcores
> > insert timers directly into timer skiplist data structures; the service core
> > directly accesses the lists as well, when looking for timers that have expired.
> >
> > To compare the burst and non-burst performance of the original and new
> > versions of the software event timer adapter, I ran the following
> > commands:
> >
> > $ sudo ./build/app/dpdk-test-eventdev -c 0xFFE -s 0xC --vdev=event_sw0 \
> > -- --test=perf_queue --plcores=4,5,6 --wlcore=7,8,9 --stlist=p \ --
> > prod_type_timerdev --worker_deq_depth=32
> >
> > $ sudo ./build/app/dpdk-test-eventdev -c 0xFFE -s 0xC --vdev=event_sw0 \
> > -- --test=perf_queue --plcores=4,5,6 --wlcore=7,8,9 --stlist=p \ --
> > prod_type_timerdev_burst --worker_deq_depth=32
> >
> > With the new version, I see a 151% improvement in throughput for the non-
> > burst case, and a 270% improvement in throughput for the burst case.
> > I also see a 53% improvement in arm latency in the non-burst case and a 65%
> > improvement in arm latency in the burst case.
> >
> > Note: To perform the test,  I commented out a check in the original version
> > that checks the adapter tick interval against a minimum value.
> >
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>
> 
> Acked-by: Jerin Jacob <jerinj at marvell.com>


Applied to dpdk-next-eventdev/master. Thanks.