[dpdk-dev] [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure

David Marchand david.marchand at redhat.com
Fri Jun 28 18:54:28 CEST 2019


On Fri, Jun 28, 2019 at 6:37 PM Honnappa Nagarahalli <
Honnappa.Nagarahalli at arm.com> wrote:

> On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli <
> honnappa.nagarahalli at arm.com<mailto:honnappa.nagarahalli at arm.com>> wrote:
> Test case for rte_rcu_qsbr_get_memsize is written specifically
> for 128 threads. Do not use RTE_MAX_LCORE as it changes for
> different configurations.
>
> Does it mean this test can only work on arm with 256 lcores?
> How many cores does this test require?
> [Honnappa] It tests the correctness of the calculation of the memory
> required. So, it uses the hand calculated number to verify. The hand
> calculated number is for 128 cores. So, it does not depend on the platform
> as such.
>
> Ah ah, funny that the default RTE_MAX_LCORE for x86 is 128, and then I did
> not see the test failing.
> Then ok for this fix.
>
> Reviewed-by: David Marchand <david.marchand at redhat.com<mailto:
> david.marchand at redhat.com>>
>
>
> How about the followup patch:
>
> -       TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384 && sz != 16768),
> -               "Get Memsize for 128 threads");
> +       TEST_RCU_QSBR_RETURN_IF_ERROR(
> +#if RTE_CACHE_LINE_SIZE == 64
> +                       sz != 8384
> +#elif RTE_CACHE_LINE_SIZE == 128
> +                       sz != 16768
> +#endif
> +               , "Get Memsize for 128 threads");
> [Honnappa] Added this change to V2, but slightly differently
>


Yep saw it.
Thanks.

-- 
David Marchand


More information about the dev mailing list