[dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter

David Marchand david.marchand at redhat.com
Fri Jun 28 21:22:18 CEST 2019


On Fri, Jun 28, 2019 at 5:57 PM Adrien Mazarguil <adrien.mazarguil at 6wind.com>
wrote:

> Rather than prefixing the return type of function prototypes with
> __rte_experimental, move it to a separate line to enhance readability.
>
> Except for checkpatches.sh, this patch was automatically generated by:
>
>  sed -i \
>      -e '/^\([^#].*\)\?__rte_experimental */{' \
>      -e 's//\1/; s/ *$//; i\' \
>      -e __rte_experimental \
>      -e '/^$/d}' \
>      $(git grep -l __rte_experimental -- '*.h')
>
> And applies on top of below commit:
>
> Fixes: 3b45414830ff ("enforce __rte_experimental at the start of symbol
> declarations")
> Cc: David Marchand <david.marchand at redhat.com>
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
>

Either way is ok for me.
But if we go with yours, we can squash this patch into mine and avoid this
"va-et-vient".

Thomas, what do you want to do?
Adrien patch1 can be caught in my patch8 by re-running the commands from
the commitlog.
Can you handle it?



-- 
David Marchand


More information about the dev mailing list