[dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd

[Xu, Rosen]

Hi,

From: David Marchand [mailto:david.marchand at redhat.com]
Sent: Thursday, February 28, 2019 16:48
To: Xu, Rosen <rosen.xu at intel.com>
Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; Zhang, Tianfei <tianfei.zhang at intel.com>; Wei, Dan <dan.wei at intel.com>; Pei, Andy <andy.pei at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>; Chen, Santos <santos.chen at intel.com>; Zhang, Zhang <zhang.zhang at intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd



On Thu, Feb 28, 2019 at 9:45 AM Xu, Rosen <rosen.xu at intel.com<mailto:rosen.xu at intel.com>> wrote:
Hi,

From: David Marchand [mailto:david.marchand at redhat.com<mailto:david.marchand at redhat.com>]
Sent: Thursday, February 28, 2019 16:37
To: Xu, Rosen <rosen.xu at intel.com<mailto:rosen.xu at intel.com>>
Cc: dev at dpdk.org<mailto:dev at dpdk.org>; Yigit, Ferruh <ferruh.yigit at intel.com<mailto:ferruh.yigit at intel.com>>; Zhang, Tianfei <tianfei.zhang at intel.com<mailto:tianfei.zhang at intel.com>>; Wei, Dan <dan.wei at intel.com<mailto:dan.wei at intel.com>>; Pei, Andy <andy.pei at intel.com<mailto:andy.pei at intel.com>>; Yang, Qiming <qiming.yang at intel.com<mailto:qiming.yang at intel.com>>; Wang, Haiyue <haiyue.wang at intel.com<mailto:haiyue.wang at intel.com>>; Chen, Santos <santos.chen at intel.com<mailto:santos.chen at intel.com>>; Zhang, Zhang <zhang.zhang at intel.com<mailto:zhang.zhang at intel.com>>
Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd


On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu at intel.com<mailto:rosen.xu at intel.com>> wrote:
Add IPN3KE support for testpmd

Signed-off-by: Rosen Xu <rosen.xu at intel.com<mailto:rosen.xu at intel.com>>
Signed-off-by: Andy Pei <andy.pei at intel.com<mailto:andy.pei at intel.com>>
---
 app/test-pmd/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index d5258ea..a6b6f6f 100644
--- a/app/test-pmd/Makefile
+++ b/app/test-pmd/Makefile
@@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
 LDLIBS += -lrte_pmd_i40e
 endif

+ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
+LDLIBS += -lrte_pmd_ipn3ke
+endif
+
 ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
 LDLIBS += -lrte_pmd_bnxt
 endif

I am a bit lost.
Why is it needed ?
Involve IPN3KE in testpmd, for testpmd is widely used in NIC.

The drivers declared in this makefile are there because testpmd directly calls private apis of those drivers.
Bis repetita, why is linking to ipn3ke needed here ?

It will be fixed in v2 patch. Thanks.

--
David Marchand