[dpdk-dev] [PATCH v3 2/2] devtools: fix result of svg include check

Michael Santana msantana at redhat.com
Fri Mar 1 18:08:06 CET 2019


Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.

Signed-off-by: Michael Santana <msantana at redhat.com>
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index d3c0b309a..16b705384 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -73,7 +73,7 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1" || res = 1
+		"$1" || res=1
 
 	return $res
 }
-- 
2.20.1



More information about the dev mailing list