[dpdk-dev] [PATCH v3] net/nfb: new netcope driver

David Marchand david.marchand at redhat.com
Mon Mar 4 13:35:36 CET 2019

On Mon, Mar 4, 2019 at 1:30 PM Rastislav Černay <cernay at netcope.com> wrote:

> >>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
> struct rte_eth_stats {
> ...
> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
> ...
> }
> As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (16)
> and struct rte_eth_stats eth_stats is allocated statically,
> there is need to check so it does not write garbage somewhere.

How about looping on min(nb_tx, RTE_ETHDEV_QUEUE_STAT_CNTRS) ?

> >>> Besides, q_errors[] is for reception errors.
> I will fix that, meanwhile could q_errors[] be renamed to q_ierrors[]?
> Also could there be a way to publish output errors per queue, for example
> q_oerrors[]?

At the moment, no, this would be a api breakage, and adding oerrors would
be a abi breakage.
This can be discussed yes, I just sent a series about q_errors[].

You can still export this via xstats.

David Marchand

More information about the dev mailing list