[dpdk-dev] [PATCH v2] meson: fix building subdirectories separately

Ranjit Menon ranjit.menon at intel.com
Tue Mar 5 19:01:37 CET 2019

On 3/5/2019 9:26 AM, Bruce Richardson wrote:
> On Tue, Mar 05, 2019 at 05:21:12PM +0000, Bruce Richardson wrote:
>> On Tue, Mar 05, 2019 at 04:29:25PM +0000, Andrius Sirvys wrote:
>>> If for debugging we disable the driver directory in the meson.build file,
>>> we get an error because the variable "driver_classes" does not exist.
>>> This is because driver_classes is only defined in the
>>> drivers/meson.build file. Defining driver_classes in dpdk/meson.build file
>>> will make it easier for compiling separate directories.
>>> In the process, we rename driver_classes to dpdk_driver_classes for
>>> consistency with the other variables.
>>> Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
>>> ---
>>> v2: Fixed mispellings in commit message
>>> ---
>> This can be useful, and a similar change I saw in the windows RFC since it
>> is incrementally adding things to the windows build, and so would hit this
>> error.
>> Therefore,
>> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> Actually, one small thing I should have picked up on earlier - I think the
> title could be reworded a bit. It's not a fix since there is nothing
> technically wrong with the existing code - it's just harder to go
> commenting out parts of the build without this change. How about setting
> the title to: "build: move variable definition to top level", or something
> similar.
> /Bruce
Yes. This will help with the Windows port.

Acked-by: Ranjit Menon <ranjit.menon at intel.com>

More information about the dev mailing list