[dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef
Zhao1, Wei
wei.zhao1 at intel.com
Fri Mar 8 07:35:19 CET 2019
Hi, David Harton
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Harton
> Sent: Wednesday, March 6, 2019 11:24 PM
> To: dev at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Ananyev,
> Konstantin <konstantin.ananyev at intel.com>
> Cc: David Harton <dharton at cisco.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for
> ixgbvef
>
> ixgevf vlan strip and extend capabilities were removed when migrating to the
> bit flags implementation.
>
> Restoring the capbility to enable these offloads at configuration time.
>
> Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
> Signed-off-by: David Harton <dharton at cisco.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index e92a70fb3..95c32257c 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
> *dev)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> + DEV_RX_OFFLOAD_VLAN_FILTER |
> + DEV_RX_OFFLOAD_VLAN_EXTEND |
> DEV_RX_OFFLOAD_SCATTER;
>
Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ?
It seems Ixgbevf do not support this configuration. Only pf does.
But this ixgbe_get_rx_port_offloads () is used by both vf and pf.
> if (hw->mac.type == ixgbe_mac_82598EB)
> offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
>
> - if (ixgbe_is_vf(dev) == 0)
> - offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_VLAN_EXTEND);
> -
> /*
> * RSC is only supported by 82599 and x540 PF devices in a non-SR-
> IOV
> * mode.
> --
> 2.19.1
More information about the dev
mailing list