[dpdk-dev] [PATCH v2 3/4] app/testpmd: remove useless casts on statistics

David Marchand david.marchand at redhat.com
Mon Mar 11 17:03:52 CET 2019

On Mon, Mar 11, 2019 at 4:57 PM Andrew Rybchenko <arybchenko at solarflare.com>

> On 3/11/19 6:35 PM, David Marchand wrote:
> Caught by code review while investigating the stats display code.
> Switching all port and fwd engine statistics to uint64_t makes it
> possible to drop all casts.
> Signed-off-by: David Marchand <david.marchand at redhat.com> <david.marchand at redhat.com>
> Patch summary is misleading here. The main change here is changing
> of counters bitwidth. 32-bit counters overflow pretty fast on 100G, so
> it is a good idea to fix it.
Oops, I was so focused on the casts and had in mind "unsigned int" was 64
bits wide...
Will reword and this will deserve a Fixes: tag.

Thanks for catching.

David Marchand

More information about the dev mailing list