[dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

Ferruh Yigit ferruh.yigit at intel.com
Mon Mar 11 18:22:34 CET 2019


On 3/4/2019 11:18 AM, David Marchand wrote:
> According to the api, the q_errors[] per queue statistic is for reception
> errors not transmit errors.
> This is a first cleanup on statistics before looking at oerrors.
> 

Yes, the patchset looks aligned with the API documentation [1].

What can be the solution after cleanup? We can merge this cleanup and solution
next to each-other to not leave a gap?
1- Different variables for Rx and Tx errors?
2- Combine Rx & Tx into this single variable?

It can be good to find a solution because new PMDs doing same mistake because of
copy/paste...

[1]
https://git.dpdk.org/dpdk/tree/lib/librte_ethdev/rte_ethdev.h?h=v19.02#n263


More information about the dev mailing list