[dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

Daly, Lee lee.daly at intel.com
Fri Mar 29 16:28:47 CET 2019


Hi Tomasz,
	After some testing I can now see the approach in your patch in the best method for getting the CPU info.
Rgds,
Lee.
> -----Original Message-----
> From: Daly, Lee
> Sent: Wednesday, March 27, 2019 3:01 PM
> To: Akhil Goyal <akhil.goyal at nxp.com>; Cel, TomaszX
> <tomaszx.cel at intel.com>; dev at dpdk.org
> Cc: stable at dpdk.org; Trahe, Fiona <fiona.trahe at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] compress/isal: fix getting information about
> CPU
> 
> Hi Tomasz,
> 
> 	This patch makes sense to check does the CPU have the capability of
> certain instructions before Adding it to the dev_info flags. I think one more
> addition should be made in isal_compress_pmd.c When checking what
> compression level should be used , decided by the AVX instructions available,
> it previously used the
> Rte_cpu_get_flag_enabled() function, however, I don’t believe that is needed
> any more since it will now be checked beforehand, it would be doing twice
> the work.
> When the driver now needs to decide the compression level it should now
> just check the feature_flags set below. Perhaps a V2 could be sent with this
> addition.
> Regards,
> Lee.
> 
> > > This patch adds query about CPU features
> > >
> > > Fixes: 53a9baa98c36 ("compress/isal: add basic PMD ops")
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: Tomasz Cel <tomaszx.cel at intel.com>
> > > ---
Acked-by: Lee Daly <lee.daly at intel.com>


More information about the dev mailing list