[dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

Thomas Monjalon thomas at monjalon.net
Sun Mar 31 17:52:15 CEST 2019

26/03/2019 10:50, Ferruh Yigit:
> > Wenzhuo Lu (8):
> >   net/ice: fix Tx function setting
> >   net/ice: add pointer for queue buffer release
> >   net/ice: support vector SSE in RX
> >   net/ice: support Rx scatter SSE vector
> >   net/ice: support Tx SSE vector
> >   net/ice: support Rx AVX2 vector
> >   net/ice: support Rx scatter AVX2 vector
> >   net/ice: support vector AVX2 in TX
> This version (v7) pulled from next-net-intel to next-net.

I assume these patches have been tested, or at least compiled.
However, when running devtools/test-meson-builds.sh, there is a
compilation error for build-x86-default:

In file included from ../drivers/net/ice/ice_ethdev.h:10:
rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found

It can be fixed in
	net/ice: support Rx AVX2 vector
by adding static_rte_pci and static_rte_bus_pci to the dependencies.
I fixed it even better in
	net/ice: support vector SSE in Rx
by replacing the useless include of rte_ethdev_pci.h in ice_ethdev.h
with rte_ethdev_driver.h.

I could just reject the next-net tree, but I don't really have such option
if we want to close 19.05-rc1 quickly.

In summary, I am spending my Sunday hours to fix the mess in your driver
which was supposed to be tested before submitting, plus before merge in
next-net-intel, plus compilation-tested before pull in next-net.
I don't know what failed in the process, but I really don't like it.
I don't want to see any new patch for ice PMD in 19.05 cycle.
If you really need some fixes in 19.05 (very likely given the mass
code drop you are doing few days before the -rc1 deadline),
then I advise you to double check everything and make commits fully
justified and explained.

Sorry for the bad mood, and I hope it won't happen again soon.

More information about the dev mailing list