[dpdk-dev] [PATCH v3 0/3] support API to set max LRO packet size

[Dekel Peled]

Hi Bernard, PSB.

> -----Original Message-----
> From: Iremonger, Bernard <bernard.iremonger at intel.com>
> Sent: Wednesday, November 6, 2019 6:41 PM
> To: Dekel Peled <dekelp at mellanox.com>; Mcnamara, John
> <john.mcnamara at intel.com>; Kovacevic, Marko
> <marko.kovacevic at intel.com>; nhorman at tuxdriver.com;
> ajit.khaparde at broadcom.com; somnath.kotur at broadcom.com; Burakov,
> Anatoly <anatoly.burakov at intel.com>; xuanziyang2 at huawei.com;
> cloud.wangxiaoyun at huawei.com; zhouguoyang at huawei.com; Lu, Wenzhuo
> <wenzhuo.lu at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Matan Azrad <matan at mellanox.com>;
> Shahaf Shuler <shahafs at mellanox.com>; Slava Ovsiienko
> <viacheslavo at mellanox.com>; rmody at marvell.com;
> shshaikh at marvell.com; maxime.coquelin at redhat.com; Bie, Tiwei
> <tiwei.bie at intel.com>; Wang, Zhihong <zhihong.wang at intel.com>;
> yongwang at vmware.com; Thomas Monjalon <thomas at monjalon.net>; Yigit,
> Ferruh <ferruh.yigit at intel.com>; arybchenko at solarflare.com; Wu, Jingjing
> <jingjing.wu at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH v3 0/3] support API to set max LRO packet size
> 
> Hi Dekel,
> 
> > -----Original Message-----
> > From: Dekel Peled <dekelp at mellanox.com>
> > Sent: Wednesday, November 6, 2019 2:28 PM
> > To: Mcnamara, John <john.mcnamara at intel.com>; Kovacevic, Marko
> > <marko.kovacevic at intel.com>; nhorman at tuxdriver.com;
> > ajit.khaparde at broadcom.com; somnath.kotur at broadcom.com; Burakov,
> > Anatoly <anatoly.burakov at intel.com>; xuanziyang2 at huawei.com;
> > cloud.wangxiaoyun at huawei.com; zhouguoyang at huawei.com; Lu,
> Wenzhuo
> > <wenzhuo.lu at intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>; matan at mellanox.com;
> > shahafs at mellanox.com; viacheslavo at mellanox.com;
> rmody at marvell.com;
> > shshaikh at marvell.com; maxime.coquelin at redhat.com; Bie, Tiwei
> > <tiwei.bie at intel.com>; Wang, Zhihong <zhihong.wang at intel.com>;
> > yongwang at vmware.com; thomas at monjalon.net; Yigit, Ferruh
> > <ferruh.yigit at intel.com>; arybchenko at solarflare.com; Wu, Jingjing
> > <jingjing.wu at intel.com>; Iremonger, Bernard
> > <bernard.iremonger at intel.com>
> > Cc: dev at dpdk.org
> > Subject: [PATCH v3 0/3] support API to set max LRO packet size
> >
> > This series implements support and use of API for configuration and
> > validation of max size for LRO aggregated packet.
> >
> > v2: Updated ethdev patch per review comments.
> > v3: Updated ethdev and testpmd patches per review comments.
> 
> My comments on the v2 testpmd patch have not been addressed in the v3
> patch.

I accepted your comment about update of function usage(), and added it in v3.
I replied your other comments in v2 reply email, and didn't see additional response.

Regards,
Dekel

> 
> >
> > Dekel Peled (3):
> >   ethdev: support API to set max LRO packet size
> >   net/mlx5: use API to set max LRO packet size
> >   app/testpmd: use API to set max LRO packet size
> >
> >  app/test-pmd/cmdline.c                      | 73
> > +++++++++++++++++++++++++++++
> >  app/test-pmd/config.c                       |  2 +
> >  app/test-pmd/parameters.c                   |  7 +++
> >  app/test-pmd/testpmd.c                      |  1 +
> >  doc/guides/nics/features.rst                |  2 +
> >  doc/guides/nics/mlx5.rst                    |  2 +
> >  doc/guides/rel_notes/deprecation.rst        |  4 --
> >  doc/guides/rel_notes/release_19_11.rst      |  8 ++++
> >  doc/guides/testpmd_app_ug/run_app.rst       |  5 ++
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  9 ++++
> >  drivers/net/bnxt/bnxt_ethdev.c              |  1 +
> >  drivers/net/hinic/hinic_pmd_ethdev.c        |  1 +
> >  drivers/net/ixgbe/ixgbe_ethdev.c            |  2 +
> >  drivers/net/ixgbe/ixgbe_vf_representor.c    |  1 +
> >  drivers/net/mlx5/mlx5.h                     |  3 ++
> >  drivers/net/mlx5/mlx5_ethdev.c              |  1 +
> >  drivers/net/mlx5/mlx5_rxq.c                 |  5 +-
> >  drivers/net/qede/qede_ethdev.c              |  1 +
> >  drivers/net/virtio/virtio_ethdev.c          |  1 +
> >  drivers/net/vmxnet3/vmxnet3_ethdev.c        |  1 +
> >  lib/librte_ethdev/rte_ethdev.c              | 44 +++++++++++++++++
> >  lib/librte_ethdev/rte_ethdev.h              |  4 ++
> >  22 files changed, 172 insertions(+), 6 deletions(-)
> >
> > --
> > 1.8.3.1
> 
> Regards,
> 
> Bernard.