[dpdk-dev] [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size
Dekel Peled
dekelp at mellanox.com
Thu Nov 7 13:18:55 CET 2019
Thanks, PSB.
> -----Original Message-----
> From: Shahed Shaikh <shshaikh at marvell.com>
> Sent: Thursday, November 7, 2019 1:57 PM
> To: Dekel Peled <dekelp at mellanox.com>; john.mcnamara at intel.com;
> marko.kovacevic at intel.com; nhorman at tuxdriver.com;
> ajit.khaparde at broadcom.com; somnath.kotur at broadcom.com;
> anatoly.burakov at intel.com; xuanziyang2 at huawei.com;
> cloud.wangxiaoyun at huawei.com; zhouguoyang at huawei.com;
> wenzhuo.lu at intel.com; konstantin.ananyev at intel.com; Matan Azrad
> <matan at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>; Slava
> Ovsiienko <viacheslavo at mellanox.com>; Rasesh Mody
> <rmody at marvell.com>; maxime.coquelin at redhat.com;
> tiwei.bie at intel.com; zhihong.wang at intel.com; yongwang at vmware.com;
> Thomas Monjalon <thomas at monjalon.net>; ferruh.yigit at intel.com;
> arybchenko at solarflare.com; jingjing.wu at intel.com;
> bernard.iremonger at intel.com
> Cc: dev at dpdk.org
> Subject: RE: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet
> size
>
> > -----Original Message-----
> > From: Dekel Peled <dekelp at mellanox.com>
> > Sent: Wednesday, November 6, 2019 7:58 PM
> > To: john.mcnamara at intel.com; marko.kovacevic at intel.com;
> > nhorman at tuxdriver.com; ajit.khaparde at broadcom.com;
> > somnath.kotur at broadcom.com; anatoly.burakov at intel.com;
> > xuanziyang2 at huawei.com; cloud.wangxiaoyun at huawei.com;
> > zhouguoyang at huawei.com; wenzhuo.lu at intel.com;
> > konstantin.ananyev at intel.com; matan at mellanox.com;
> > shahafs at mellanox.com; viacheslavo at mellanox.com; Rasesh Mody
> > <rmody at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>;
> > maxime.coquelin at redhat.com; tiwei.bie at intel.com;
> > zhihong.wang at intel.com; yongwang at vmware.com;
> thomas at monjalon.net;
> > ferruh.yigit at intel.com; arybchenko at solarflare.com;
> > jingjing.wu at intel.com; bernard.iremonger at intel.com
> > Cc: dev at dpdk.org
> > Subject: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO
> > packet size
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > This patch implements [1], to support API for configuration and
> >
> > validation of max size for LRO aggregated packet.
> >
> > API change notice [2] is removed, and release notes for 19.11
> >
> > are updated accordingly.
> >
> >
> >
> > Various PMDs using LRO offload are updated, the new data members are
> >
> > initialized to ensure they don't fail validation.
> >
> >
> >
> > [1]
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld
> > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp-
> &data=02%7C01%7Cdekelp
> >
> %40mellanox.com%7Cabfce6c19bcf4f42c75208d76379d781%7Ca652971c7d2e
> 4d9ba
> >
> 6a4d149256f461b%7C0%7C1%7C637087247277571736&sdata=gWGd5Ew
> ntdYj44F
> > PZXNTG0uMivl42B0bE2%2FZ2izxV%2Fo%3D&reserved=0
> >
> 3A__patches.dpdk.org_patch_58217_&d=DwIBAg&c=nKjWec2b6R0mOyPaz
> 7xtf
> > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D-
> >
> cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ANfM9
> GH
> > SB9nUhm8O8YaoqcXO0eTBO7TmGhVmekbNO6U&e=
> >
> > [2]
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld
> > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp-
> &data=02%7C01%7Cdekelp
> >
> %40mellanox.com%7Cabfce6c19bcf4f42c75208d76379d781%7Ca652971c7d2e
> 4d9ba
> >
> 6a4d149256f461b%7C0%7C1%7C637087247277571736&sdata=gWGd5Ew
> ntdYj44F
> > PZXNTG0uMivl42B0bE2%2FZ2izxV%2Fo%3D&reserved=0
> >
> 3A__patches.dpdk.org_patch_57492_&d=DwIBAg&c=nKjWec2b6R0mOyPaz
> 7xtf
> > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D-
> >
> cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ppYVW
> Xe
> > Jj3xhnvWCV2hIfNu6wy9N2r5lvJxgJnHKfSc&e=
> >
> >
> >
> > Signed-off-by: Dekel Peled <dekelp at mellanox.com>
> >
> > Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
> >
> > Acked-by: Thomas Monjalon <thomas at monjalon.net>
> >
> > ---
> >
> > doc/guides/nics/features.rst | 2 ++
> >
> > doc/guides/rel_notes/deprecation.rst | 4 ---
> >
> > doc/guides/rel_notes/release_19_11.rst | 8 ++++++
> >
> > drivers/net/bnxt/bnxt_ethdev.c | 1 +
> >
> > drivers/net/hinic/hinic_pmd_ethdev.c | 1 +
> >
> > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> >
> > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 +
> >
> > drivers/net/mlx5/mlx5.h | 3 +++
> >
> > drivers/net/mlx5/mlx5_ethdev.c | 1 +
> >
> > drivers/net/mlx5/mlx5_rxq.c | 1 -
> >
> > drivers/net/qede/qede_ethdev.c | 1 +
> >
> > drivers/net/virtio/virtio_ethdev.c | 1 +
> >
> > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 +
> >
> > lib/librte_ethdev/rte_ethdev.c | 44
> > ++++++++++++++++++++++++++++++++
> >
> > lib/librte_ethdev/rte_ethdev.h | 4 +++
> >
> > 15 files changed, 70 insertions(+), 5 deletions(-)
> >
> > @@ -1277,6 +1277,7 @@ static int qede_dev_configure(struct rte_eth_dev
> > *eth_dev)
> >
> >
> >
> > dev_info->min_rx_bufsize = (uint32_t)QEDE_MIN_RX_BUFF_SIZE;
> >
> > dev_info->max_rx_pktlen =
> > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN;
> >
> > + dev_info->max_lro_pkt_size =
> > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN
>
> Please use 0x7FFF instead of ETH_TX_MAX_NON_LSO_PKT_LEN.
>
Sending v4 with this change.
> We set the same limit in qede_ethdev.c: qede_update_sge_tpa_params()
>
> sge_tpa_params->tpa_max_size = 0x7FFF;
>
> Thanks,
> Shahed
> >
> > dev_info->rx_desc_lim = qede_rx_desc_lim;
> >
> > dev_info->tx_desc_lim = qede_tx_desc_lim;
> >
> >
Regards,
Dekel
More information about the dev
mailing list