[dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags
Ferruh Yigit
ferruh.yigit at intel.com
Mon Nov 11 16:45:45 CET 2019
On 11/11/2019 1:19 PM, pbhagavatula at marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>
> Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used
> to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also
> `ol_flags:PKT_RX_RSS`.
>
> Add new packet type set function `rte_eth_dev_set_ptypes`,
> allows application to inform PMDs about the packet types it is interested
> in. Based on ptypes requested by application PMDs can optimize the Rx path.
>
> For example, if a given PMD doesn't support any packet types that the
> application is interested in then the application can disable[1] writes to
> `mbuf.packet_type` done by the PMD and use a software ptype parser.
> [1] rte_eth_dev_set_ptypes(*port_id*, RTE_PTYPE_UNKNOWN,
> NULL, 0);
>
> v17 Changes:
> -----------
> - Split 8/8 into two patches.
> - Add rss_hash to port rx_offloads in testpmd.
> - Add log when set_ptype fails.
> - Fix few spell check.
>
> v16 Changes:
> -----------
> - Fix testpmd documentation(Bernard).
> - s/rte_eth_dev_set_supported_ptypes/rte_eth_dev_set_ptypes.
> - Fix release notes placement.
> - Enhance offload validation(Andrew).
> - Remove if condition in drivers/net while enabling RSS_HASH by default.
> - Spilt 5/7 into two patches.
>
> v15 Changes:
> -----------
> - Fix sfc RSS_HASH offload check.
> - Fix ethdev RSS_HASH offload check when mq_mode is configured with
> MQ_RX_NONE.
> - Extend offload validation to return error in the case where application
> has requested an offload to be enabled and PMD couldn't honor it.
>
> v14 Changes:
> -----------
> - Remove log from drives
> - Add log in rte_eth_dev_configure when certain offloads are requested to be
> disabled and PMD cannot honor the request.
> - Make changes to default offloads in net/sfc.(Andrew)
>
> v13 Changes:
> -----------
> - Remove DEV_RX_OFFLOAD_FLOW_MARK from this patchset to allow foreward
> progress will be sent as a seperate patch.
> - Use set_supported function only for l2fwd and testpmd.
> - Add info log in drivers which expose the DEV_RX_OFFLOAD_RSS_HASH
> indicating that disabling DEV_RX_OFFLOAD_RSS_HASH is not supported.
> - Few documentation changes.
>
> v12 Changes:
> -----------
> - Rebase onto next-net.
>
> v11 Changes:
> -----------
> - Use RTE_DIM to get array size.
> - Since we are using a list of MASKs to validate ptype_mask return -EINVAL
> if any unknown mask is set.
> - Rebase to TOT.
>
> v10 Changes:
> -----------
> - Modify ptype_mask validation in set_supported_ptypes.(Andrew)
>
> v9 Changes:
> ----------
> - Add ptype_mask validation in set_supported_ptypes.(Andrew)
> - Make description more verbose.
>
> v8 Changes:
> ----------
> - Make description more verbose.
> - Set RTE_PTYPE_UNKNOWN in set_ptypes array when either get ot set ptypes
> is not supported by ethernet device.
>
> v7 Changes:
> ----------
> - Fix unused variable in net/octeontx2
>
> v6 Changes:
> ----------
> - Add additional checks for set supported ptypes.(Andrew)
> - Clarify `rte_eth_dev_set_supported_ptypes` documentation.
> - Remove DEV_RX_OFFLOAD_FLOW_MARK emulation from net/octeontx2.
>
> v5 Changes:
> ----------
> - Fix typos.
>
> v4 Changes:
> ----------
> - Set the last element in set_ptype array as RTE_PTYPE_UNKNOWN to mark the end
> of array.
> - Fix invalid set ptype function call in examples.
> - Remove setting rte_eth_dev_set_supported_ptypes to UNKNOWN in l3fwd-power.
>
> v3 Changes:
> ----------
> - Add missing release notes. (Andrew)
> - Re-word various descriptions.
> - Fix ptype set logic.
>
> v2 Changes:
> ----------
> - Update release notes. (Andrew)
> - Redo commit logs. (Andrew)
> - Disable ptype parsing for unsupported examples. (Jerin)
> - Disable RSS write only in generic mode eventdev_pipeline. (Jerin)
> - Modify set_supported_ptypes function to return successfuly set mask
> instead of failure.
> - Dropped set_supported_ptypes to drivers by handling in library
> layer, interested PMD can add it in.
>
> Pavan Nikhilesh (10):
> ethdev: add set ptype function
> ethdev: add mbuf RSS update as an offload
> ethdev: add validation to offloads set by PMD
> drivers/net: update Rx RSS hash offload capabilities
> examples/eventdev_pipeline: split port init sequence
> examples/eventdev_pipeline: add new Rx RSS hash offload
> examples/l2fwd: disable ptype parsing
> app/testpmd: add command to set supported ptype mask
> app/testpmd: disable packet type parsing by default
> app/testpmd: add RSS hash offload to port Rx offload cmd
For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
Series applied to dpdk-next-net/master, thanks.
More information about the dev
mailing list