[dpdk-dev] [PATCH] kni: reduce interface name size
Ferruh Yigit
ferruh.yigit at intel.com
Fri Nov 15 13:43:33 CET 2019
On 11/15/2019 12:30 PM, Igor Ryzhov wrote:
> Hi Michael,
>
> Isn't it better to set it to IFNAMSIZ instead of 16?
I was thinking same, but "linux/if.h" included only for kernel, so instead of
introducing new dependency in user side, perhaps better to keep it as hardcoded
value.
>
> Best regards,
> Igot
>
> On Fri, Nov 15, 2019 at 2:41 PM Michael Pfeiffer <michael.pfeiffer at tu-ilmenau.de
> <mailto:michael.pfeiffer at tu-ilmenau.de>> wrote:
>
> The name in rte_kni_device_info is passed to the kernel, which allows
> interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a
> longer name currently trigger a kernel BUG in alloc_netdev_mqs in
> net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation.
>
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer at tu-ilmenau.de
> <mailto:michael.pfeiffer at tu-ilmenau.de>>
> ---
> lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h
> b/lib/librte_eal/linux/eal/include/rte_kni_common.h
> index 46f75a710..59339271b 100644
> --- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
> +++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
> @@ -18,7 +18,7 @@
> /**
> * KNI name is part of memzone name.
> */
> -#define RTE_KNI_NAMESIZE 32
> +#define RTE_KNI_NAMESIZE 16
>
> #define RTE_CACHE_LINE_MIN_SIZE 64
>
> --
> 2.20.1
>
More information about the dev
mailing list