[dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version
Thomas Monjalon
thomas at monjalon.net
Tue Nov 19 17:05:30 CET 2019
19/11/2019 16:38, Burakov, Anatoly:
> On 19-Nov-19 2:01 PM, Thomas Monjalon wrote:
> > 08/11/2019 17:25, Anatoly Burakov:
> >> From: Pawel Modrak <pawelx.modrak at intel.com>
> >>
> >> Add a script that automatically merges all stable ABI's under one
> >> ABI section with the new version, while leaving experimental
> >> section exactly as it is.
> >>
> >> Signed-off-by: Pawel Modrak <pawelx.modrak at intel.com>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> >> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> >> ---
> >> --- /dev/null
> >> +++ b/buildtools/update_version_map_abi.py
> >> +"""
> >> +A Python program to update the ABI version and function names in a DPDK
> >> +lib_*_version.map file. Called from the buildtools/update_abi.sh utility.
> >> +"""
> >
> > Clearly this script is doing more than updating a version number and names.
> > I already see more in the commit log.
> > Please would you like to add something in this description?
>
> Not sure what you're referring to. That's exactly what it's doing. What
> else is there that i'm missing?
"merges all stable ABI's under one ABI section"
"while leaving experimental section exactly as it is"
I think this needs to be in the comment at the top of the file,
so we have an introduction for the code in the rest of the file.
More information about the dev
mailing list