[dpdk-dev] [PATCH] ethdev: fix missed item expansion for RSS flow
Matan Azrad
matan at mellanox.com
Tue Nov 26 10:04:10 CET 2019
When the last item in flow pattern includes "next protocol" field which
is relevant for RSS flow expansion, a new item is added to the pattern
according to the "next protocol" field. This field is called missed
field.
The missed field wrongly was not initialized what caused to some of the
flow item fields to contain garbage values.
As a result, the PMDs internal flow engine may crash.
For example, the spec value may include garbage pointer and to cause
crash.
Initialize the missed field with zeroes.
Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
Cc: jackmin at mellanox.com
Signed-off-by: Matan Azrad <matan at mellanox.com>
Acked-by: Ori Kam <orika at mellanox.com>
---
lib/librte_ethdev/rte_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index d7f29e5..87a3e8c 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -1071,6 +1071,7 @@ enum rte_flow_conv_item_spec_type {
int elt = 0;
const struct rte_flow_item *last_item = NULL;
+ memset(&missed_item, 0, sizeof(missed_item));
lsize = offsetof(struct rte_flow_expand_rss, entry) +
elt_n * sizeof(buf->entry[0]);
if (lsize <= size) {
--
1.8.3.1
More information about the dev
mailing list