[dpdk-dev] [RFC 0/6] Add ABI compatibility checks to the meson build
David Marchand
david.marchand at redhat.com
Fri Nov 29 13:13:02 CET 2019
Hello Kevin,
On Wed, Oct 23, 2019 at 11:26 AM Kevin Laatz <kevin.laatz at intel.com> wrote:
>
> With the recent changes made to stabilize ABI versioning in DPDK, it will
> become increasingly important to check patches for ABI compatibility. We
> propose adding the ABI compatibility checking to be done as part of the
> build.
>
> The advantages to adding the ABI compatibility checking to the build are
> two-fold. Firstly, developers can easily check their patches to make sure
> they don’t break the ABI without adding any extra steps. Secondly, it
> makes the integration into existing CI seamless since there are no extra
> scripts to make the CI run. The build will run as usual and if an
> incompatibility is detected in the ABI, the build will fail and show the
> incompatibility. As an added bonus, enabling the ABI compatibility checks
> does not impact the build speed.
>
> The proposed solution works as follows:
> 1. Generate the ABI dump of the baseline. This can be done with the new
> script added in this RFC. This step will only need to be done when the
> ABI version changes (so once a year) and can be added to master so it
> exists by default. This step can be skipped if the dump files for the
> baseline already exist.
> 2. Build with meson. If there is an ABI incompatibility, the build will
> fail and print the incompatibility information.
>
> The patches accompanying this RFC add the ABI dump file generating script,
> the meson option required to enable/disable the checks, and the required
> meson changes to run the compatibility checks during the build.
Could you rebase this series on master?
Thanks.
--
David Marchand
More information about the dev
mailing list