[dpdk-dev] [PATCH v3] eventdev: flag to identify same destined packets enqueue

[Jerin Jacob]

On Fri, Oct 4, 2019 at 4:33 PM Nipun Gupta <nipun.gupta at nxp.com> wrote:
>
> This patch introduces a `flag` in the Eth TX adapter enqueue API.
> Some drivers may support burst functionality only with the packets
> having same destination device and queue.
>
> The flag `RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST` can be used
> to indicate this so the underlying driver, for drivers to utilize
> burst functionality appropriately.
>
> Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> ---
>
> Changes in v3:
>  - remove flag from internal txa_enqueue_same_dest internal API
>  - ABI version update in makefile, meson and rel_notes
>  - Few comments update
>
> Changes in v2:
>  - have separate internal API in tx adapter for sending burst packets to
>    same eth dev, queue pair on the basis of the passed flag
>  - fix compilation of examples/eventdev_pipeline/

>                 event.queue_id = qid; /* event queue linked to adapter port */
> diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst
> index 27cfbd9e3..e589e020e 100644
> --- a/doc/guides/rel_notes/release_19_11.rst
> +++ b/doc/guides/rel_notes/release_19_11.rst
> @@ -146,7 +146,7 @@ The libraries prepended with a plus sign were incremented in this version.
>       librte_eal.so.11
>       librte_efd.so.1
>       librte_ethdev.so.12
> -     librte_eventdev.so.7
> +     librte_eventdev.so.8
>       librte_flow_classify.so.1
>       librte_gro.so.1
>       librte_gso.so.1


Forgot to update "API Changes" section in doc/guides/rel_notes/release_19_11.rst

> +static uint16_t
> +rte_event_tx_adapter_enqueue_same_dest(__rte_unused void *port,
> +                       __rte_unused struct rte_event ev[],
> +                       __rte_unused uint16_t nb_events)
> +{
> +       rte_errno = ENOTSUP;
> +       return 0;
> +}
> +
>  struct rte_eventdev *
>  rte_event_pmd_allocate(const char *name, int socket_id)
>  {
> @@ -1351,6 +1360,8 @@ rte_event_pmd_allocate(const char *name, int socket_id)
>         eventdev = &rte_eventdevs[dev_id];
>
>         eventdev->txa_enqueue = rte_event_tx_adapter_enqueue;
> +       eventdev->txa_enqueue_same_dest =
> +                       rte_event_tx_adapter_enqueue_same_dest;

We may not need to add new rte_event_tx_adapter_enqueue_same_dest function
as it is same as rte_event_tx_adapter_enqueue() and can simply assign
txa_enqueue_same_dest  as rte_event_tx_adapter_enqueue. No strong
opinion on this.


With the above changes:
Acked-by: Jerin Jacob <jerinj at marvell.com>

I wait for a week for any review comments, If none, I will merge your
next revision.