[dpdk-dev] [PATCH] service: improve service run performance

[Van Haaren, Harry]

> -----Original Message-----
> From: David Marchand [mailto:david.marchand at redhat.com]
> Sent: Monday, October 7, 2019 3:53 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev <dev at dpdk.org>; Rao, Nikhil <nikhil.rao at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] service: improve service run performance
> 
> On Mon, Sep 16, 2019 at 12:01 PM Nikhil Rao <nikhil.rao at intel.com> wrote:
> >
> > For a valid service, the core mask of the service
> > is checked against the current core and the corresponding
> > entry in the active_on_lcore array is set or reset.
> >
> > Upto 8 cores share the same cache line for their
> > service active_on_lcore array entries since each entry is a uint8_t.
> > Some number of these entries also share the cache line with
> > the internal_flags member of struct rte_service_spec_impl,
> > hence this false sharing also makes the service_valid() check
> > expensive.
> >
> > Eliminate false sharing by moving the active_on_lcore array to
> > a per-core data structure. The array is now indexed by service id.
> 
> Harry, any comments on this patch?


Looks good to me, thanks Nikhil & David for the ping;

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>