[dpdk-dev] 答复: [PATCH] crypto/virtio: alloc private data by NUMA affinity

[Zhoujian (jay)]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
> Sent: Friday, October 4, 2019 8:00 PM
> To: Zhoujian (jay) <jianjay.zhou at huawei.com>
> Cc: dev at dpdk.org; Xiao Wang <xiao.w.wang at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA
> affinity
> 
> Hi Jay,
> 
> Could you please review this change.
> 
> Thanks,
> Akhil

Hi Akhil,

Sure, sorry for the late response.

Thanks,
Jay

> 
> >
> > It's better to allocate device private data on the same NUMA node with
> > device, rather than with the main thread. This helps avoid cross-NUMA
> > access for worker thread.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
> > ---
> >  drivers/crypto/virtio/virtio_cryptodev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/virtio/virtio_cryptodev.c
> > b/drivers/crypto/virtio/virtio_cryptodev.c
> > index f16bdfe57..4af479f54 100644
> > --- a/drivers/crypto/virtio/virtio_cryptodev.c
> > +++ b/drivers/crypto/virtio/virtio_cryptodev.c
> > @@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe(  {
> >  	struct rte_cryptodev_pmd_init_params init_params = {
> >  		.name = "",
> > -		.socket_id = rte_socket_id(),
> > +		.socket_id = pci_dev->device.numa_node,
> >  		.private_data_size = sizeof(struct virtio_crypto_hw)
> >  	};
> >  	char name[RTE_CRYPTODEV_NAME_MAX_LEN];
> > --
> > 2.15.1