[dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci

[Akhil Goyal]

Hi Fiona,

Could you please Ack the following change.

Thanks,
Akhil

> -----Original Message-----
> From: Damian Nowak <damianx.nowak at intel.com>
> Sent: Friday, August 9, 2019 2:59 PM
> To: dev at dpdk.org
> Cc: Akhil Goyal <akhil.goyal at nxp.com>; fiona.trahe at intel.com;
> arkadiuszx.kusztal at intel.com; Damian Nowak <damianx.nowak at intel.com>
> Subject: [PATCH] crypto/qat: fix null auth issues when using vfio_pci
> 
> When running auth NULL cases while using
> vfio_pci, DMAR read/write faults appear. It
> happens even if digest_length is set to 0.
> This is caused by auth_res_addr initialized
> as 0x0.
> 
> Fixes: 4e0955bddb08
> Cc: Fiona Trahe <fiona.trahe at intel.com>
> 
> Signed-off-by: Damian Nowak <damianx.nowak at intel.com>
> ---
>  drivers/crypto/qat/qat_sym.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
> index 46ef27a..6aa514c 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -307,9 +307,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
>  		}
>  		min_ofs = auth_ofs;
> 
> -		if (likely(ctx->qat_hash_alg !=
> ICP_QAT_HW_AUTH_ALGO_NULL))
> -			auth_param->auth_res_addr =
> -					op->sym->auth.digest.phys_addr;
> +		auth_param->auth_res_addr =
> +			op->sym->auth.digest.phys_addr;
> 
>  	}
> 
> --
> 2.7.4