[dpdk-dev] [PATCH v3 6/9] distributor: remove deprecated code

Hunt, David david.hunt at intel.com
Thu Oct 17 12:53:27 CEST 2019


On 16/10/2019 18:03, Anatoly Burakov wrote:
> From: Marcin Baran <marcinx.baran at intel.com>
>
> Remove code for old ABI versions ahead of ABI version bump.
>
> Signed-off-by: Marcin Baran <marcinx.baran at intel.com>
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> ---
>
> Notes:
>      v3:
>      - Removed single mode from distributor as per Dave's comments


Hi Anatoly,

Having looked at this code closer, I see that this now breaks the API 
for when a distributor instance is created with the RTE_DIST_ALG_SINGLE.

I think now that the better solution would be to just re-name the _v20 
to _single for structs, functions, etc, as you did in the previous patch 
version. That means that the unit and perf tests should still work 
unchanged, and maintain the API.

Rgds,
Dave.




More information about the dev mailing list