[dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs
Joyce Kong
joyce.kong at arm.com
Wed Oct 23 04:54:52 CEST 2019
There are a lot functions of bit operations scattered in PMDs,
consolidate them into a common API family and applied in different
PMDs to reduce code duplication.
v2:
1. Add doxygen comments for the rte bit operation API(suggested by Stephen Hemminger).
2. Add test cases for common rte bit operation API(suggested by Stephen Hemminger).
3. Change the header file to rte_io_bitops.h and the operation to rte_io_set_bit()etc.,
as the API uses barriers inside and the barriers are only needed for IO operations
(suggested by Jerin Jacob).
4. Use an well defined uint_NN_t type(suggested by Morten Brørup).
Joyce Kong (6):
lib/eal: implement the family of rte bit operation APIs
test/iobitops: add io bit operation test case
net/axgbe: use common rte bit operation APIs instead
net/bnx2x: use common rte bit operation APIs instead
net/hinic: use common rte bit operation APIs instead
net/qede: use common rte bit operation APIs instead
app/test/Makefile | 1 +
app/test/test_io_bitops.c | 86 +++++++++++
drivers/net/axgbe/axgbe_common.h | 29 +---
drivers/net/axgbe/axgbe_ethdev.c | 14 +-
drivers/net/axgbe/axgbe_mdio.c | 14 +-
drivers/net/bnx2x/bnx2x.c | 209 ++++++++++++--------------
drivers/net/bnx2x/bnx2x.h | 4 -
drivers/net/bnx2x/ecore_sp.h | 9 +-
drivers/net/hinic/base/hinic_compat.h | 35 +----
drivers/net/hinic/hinic_pmd_ethdev.c | 16 +-
drivers/net/qede/base/bcm_osal.c | 20 ---
drivers/net/qede/base/bcm_osal.h | 10 +-
lib/librte_eal/common/Makefile | 1 +
lib/librte_eal/common/include/rte_io_bitops.h | 112 ++++++++++++++
lib/librte_eal/common/meson.build | 1 +
15 files changed, 327 insertions(+), 234 deletions(-)
create mode 100644 app/test/test_io_bitops.c
create mode 100644 lib/librte_eal/common/include/rte_io_bitops.h
--
2.7.4
More information about the dev
mailing list